feat(ui) micro-frontend basic configuration #15069
Conversation
DATAMGT-5231: micro-frontend basic configuration
github-actions
bot
added
product
Bundle ReportBundle size has no change ✅ |
datahub-cyborg
bot
added
the
needs-review
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
DATAMGT-5231: add MFEConfigurableContainer.tsx
| 'module', | ||
| 'flags', | ||
| 'permissions', | ||
| 'navIcon', |
There was a problem hiding this comment.
why do we want to keep navIcon required?
| */ | ||
| export function loadMFEConfigFromYAML(yamlString: string): MFESchema { | ||
| try { | ||
| console.log('[MFE Loader] Raw YAML:', yamlString); |
There was a problem hiding this comment.
this may be unnecessary and also can lead to exposure of unnecessary data. Also could be wrapped around only for dev environments if needed.
| } | ||
| const config = loadMFEConfigFromYAML(mfeYamlRaw); | ||
| if (config) { | ||
| console.log('[MFE Loader] useMFEConfigFromYAML loaded:', config); |
There was a problem hiding this comment.
same here, we don't need to log this on every page
| throw new Error('[MFE Loader] Invalid YAML: missing microFrontends array'); | ||
| } | ||
| // Validate each entry, keeping both valid and invalid ones | ||
| parsed.microFrontends = parsed.microFrontends.map(validateMFEConfig); |
There was a problem hiding this comment.
we could also just filter out here instead of storing the InvalidMFEConfig and passing around.
ani-malgari
left a comment
ani-malgari
left a comment
There was a problem hiding this comment.
Also may be i'm lacking context, how do you envision to provide the mfe config since the app will be bundled?
| } | ||
|
|
||
| export function useDynamicRoutes(): JSX.Element[] { | ||
| const mfeConfig = useMFEConfigFromYAML(); |
There was a problem hiding this comment.
is the idea here that this will be replaced one day with useMFEConfigFromRemote?
3 participants
Basic setup for YAML-based configuration of micro frontends.
Includes tests and readme.
The config will be use in subsequent PRs